fix: helm chart service label indentation issues by liymike · Pull Request #768 · Project-HAMi/HAMi

liymike · 2025-01-02T06:34:40Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

This pull request fixes an indentation issue in the labels section under

device-plugin/monitorservice.yaml
scheduler/service.yaml

in the Helm chart.

Which issue(s) this PR fixes:
Fixes #

Currently, the custom service labels are indented with 4 extra spaces, which is inconsistent with the other labels like below.

apiVersion: v1
kind: Service
metadata:
  name: hami-device-plugin-monitor
  labels:
    app.kubernetes.io/component: hami-device-plugin
    helm.sh/chart: hami-2.4.1
    app.kubernetes.io/name: hami
    app.kubernetes.io/instance: hami
    app.kubernetes.io/version: "2.4.1"
    app.kubernetes.io/managed-by: Helm
        monitored-by: vm

This PR corrects the indentation to align with the rest of the labels.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

trivy:fix specify card type to use error

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

…node. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>

fix: When a node cannot bind, it should stop scheduling pods to that node

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Support GPU Utilization Metrics

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

…lect-param scheduler server add leader elect

KEP: add scheduler policy design doc and code

…ld be thrown

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

* update architect png

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.3 to 4.5.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.4.3...v4.5.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: jinye <jinye.shi@daocloud.io>

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.9.0 to 6.10.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6.9.0...v6.10.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…he image display problem in document; Change deployment/values.yaml before deploying dcgm-exporter. Signed-off-by: jiangsanyin <1327212357@qq.com>

Signed-off-by: 逍遥 <dongkui0712@foxmail.com>

Signed-off-by: yintong.huang <yintong.huang@daocloud.io>

* update documents Signed-off-by: limengxuan <391013634@qq.com>

Signed-off-by: elrondwong <gfengwong@gmail.com>

add-nodelock-ut Signed-off-by: learner0810 <zhongjun.li@daocloud.io>

Signed-off-by: penguin <lihan.zhou@daocloud.io>

* update nodelock for mig instance & add document for mig monitor Signed-off-by: limengxuan <391013634@qq.com>

* update documents for config Signed-off-by: limengxuan <391013634@qq.com>

* Setting devicePlugin.compatWithCPUManager=true will set PASS_DEVICE_SPECS=true as an environment variable. Signed-off-by: 张驰 <919474320@qq.com> * Change the parameter compatWithCPUManager for setting the PASS_DEVICE_SPECS ENV to passDeviceSpecsEnabled, and set the default value to true. Signed-off-by: 张驰 <919474320@qq.com> --------- Signed-off-by: 张驰 <919474320@qq.com>

Signed-off-by: learner0810 <zhongjun.li@daocloud.io>

…ler. (Project-HAMi#746) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

…t-HAMi#735) Signed-off-by: elrondwong <gfengwong@gmail.com>

Signed-off-by: bin <bin.pan@daocloud.io>

Signed-off-by: elrondwong <gfengwong@gmail.com>

Signed-off-by: bin <bin.pan@daocloud.io>

* add star history to readme, fix typos and add more contributors and maintainers. Signed-off-by: yangshiqi <yangshiqi1089@gmail.com> * add spaces Signed-off-by: yangshiqi <yangshiqi1089@gmail.com> --------- Signed-off-by: yangshiqi <yangshiqi1089@gmail.com>

Signed-off-by: Fengyang <495160589@qq.com>

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>

Signed-off-by: yxxhero <aiopsclub@163.com>

lengrongfu · 2025-03-25T03:08:56Z

@liymike place rebase latest code.

mesutoezdil · 2026-06-25T08:24:59Z

@liymike rebase requested by @lengrongfu in March 2025, no response since. Please rebase.

mesutoezdil · 2026-06-29T09:28:16Z

Hi,

We are going through open pull requests to keep things manageable. This PR was opened before 2026 and has not been merged or updated recently.

Please reply by 2026-07-13 to confirm this is still relevant and based on the current codebase. If we do not hear back, we will close this PR. You are welcome to reopen it or submit a new one when ready.

Thank you for your contribution to HAMi.

Xiao Zhang and others added 30 commits April 12, 2024 15:15

Merge pull request Project-HAMi#266 from wawa0210/master

7068d17

trivy:fix specify card type to use error

update hami license and add license check (Project-HAMi#268)

30c896e

fix bad link in README (Project-HAMi#270)

3617dde

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

add aliases import validation

2c1c469

fix: When a node cannot bind, it should stop scheduling pods to that …

9f445ac

…node. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

update CONTRIBUTING.md

3b7b606

Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>

Merge pull request Project-HAMi#273 from chaunceyjiang/bind

4e9dedb

fix: When a node cannot bind, it should stop scheduling pods to that node

Support GPU Utilization Metrics

b918011

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

support new cambricon devices

68e3e3a

remove unused files

182fe85

update mlu-related docs and examples

d9a8726

Merge pull request Project-HAMi#280 from chaunceyjiang/device_util

c3c1d15

Support GPU Utilization Metrics

update libvgpu

1e781d7

Merge branch 'master' of github.com:Project-HAMi/HAMi

103b2b6

add scheduler policy design doc

0e2a6e4

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

scheduler server add leader elect

d472283

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

Merge pull request Project-HAMi#196 from lengrongfu/feat/add-leader-e…

e4a4600

…lect-param scheduler server add leader elect

Merge pull request Project-HAMi#152 from lengrongfu/add_scheduler_policy

4f1a323

KEP: add scheduler policy design doc and code

fix nvidia device plugin nodename init sort error

c30db33

fix metrics error

4dd84d3

Merge branch 'master' of github.com:Project-HAMi/HAMi

e892934

fix RegistrInAnnotation log time error

90af849

fix device plugin crash whrn numa get err (Project-HAMi#290)

54715cd

update

d59ef57

Merge branch 'master' of github.com:Project-HAMi/HAMi

f859cf9

To avoid swallowing exception information during device stop, it shou…

d770a47

…ld be thrown

add break change document

de36c8c

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

Replace project architecture diagram (Project-HAMi#296)

7a5b7ea

* update architect png

fix gpu type matching mechanism

e678dbe

triv:Remove the build double quotes

fd8deca

dependabot Bot and others added 26 commits December 19, 2024 13:49

random time may be zero

9056fd3

Signed-off-by: jinye <jinye.shi@daocloud.io>

fix grafana dashboard and clarify dashboard usage more clearly; Fix t…

3c220fc

…he image display problem in document; Change deployment/values.yaml before deploying dcgm-exporter. Signed-off-by: jiangsanyin <1327212357@qq.com>

update examples and README

b5a8b27

Signed-off-by: 逍遥 <dongkui0712@foxmail.com>

fix docs

c499ab5

Signed-off-by: 逍遥 <dongkui0712@foxmail.com>

add ut for github.com/Project-HAMi/HAMi/pkg/scheduler/pod.go

659bef8

Signed-off-by: yintong.huang <yintong.huang@daocloud.io>

Add design document to 'dynamic-mig' feature (Project-HAMi#725)

28a0528

* update documents Signed-off-by: limengxuan <391013634@qq.com>

fix(doc): fix a typo and resolve markdown warnings in the tasklist

a0a007b

Signed-off-by: elrondwong <gfengwong@gmail.com>

add-nodelock-ut (Project-HAMi#719)

6d70d6c

add-nodelock-ut Signed-off-by: learner0810 <zhongjun.li@daocloud.io>

test: add ut about pkg/version/version.go (Project-HAMi#677)

88c6b62

Signed-off-by: penguin <lihan.zhou@daocloud.io>

Update on mig mode (Project-HAMi#726)

cd12260

* update nodelock for mig instance & add document for mig monitor Signed-off-by: limengxuan <391013634@qq.com>

Update documents for config & config_cn (Project-HAMi#729)

311d18b

* update documents for config Signed-off-by: limengxuan <391013634@qq.com>

fix device-plugin-version (Project-HAMi#743)

6353e9e

Signed-off-by: learner0810 <zhongjun.li@daocloud.io>

feat: Return the nodes that failed to be scheduled back to the schedu…

35813b5

…ler. (Project-HAMi#746) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

fix(log): fix missing log output in nvidiadeviceplugin server (Projec…

b6ad0c6

…t-HAMi#735) Signed-off-by: elrondwong <gfengwong@gmail.com>

support configuration resources limits and requests

5839076

Signed-off-by: bin <bin.pan@daocloud.io>

feat(test): add TestMarshalNodeDevices scenarios

96adaec

Signed-off-by: elrondwong <gfengwong@gmail.com>

print flags for device-plugin and scheduler

ac1d91d

Signed-off-by: bin <bin.pan@daocloud.io>

Add a mind map to help understand this project (Project-HAMi#764)

9fdbd5f

Signed-off-by: Fengyang <495160589@qq.com>

update config pages (Project-HAMi#760)

f92c7ca

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>

add ut for device-map

f8c97ee

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>

refactor(ci): use go.mod file for Go version in workflows

b8548c3

Signed-off-by: yxxhero <aiopsclub@163.com>

fix: helm chart service label indentation issues

602229f

archlitchi force-pushed the master branch from ef0d42b to c79824a Compare January 20, 2026 04:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: helm chart service label indentation issues#768

fix: helm chart service label indentation issues#768
liymike wants to merge 742 commits into
Project-HAMi:masterfrom
liymike:master

liymike commented Jan 2, 2025 •

edited

Loading

Uh oh!

lengrongfu commented Mar 25, 2025

Uh oh!

mesutoezdil commented Jun 25, 2026 •

edited

Loading

Uh oh!

mesutoezdil commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

liymike commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lengrongfu commented Mar 25, 2025

Uh oh!

mesutoezdil commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mesutoezdil commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

liymike commented Jan 2, 2025 •

edited

Loading

mesutoezdil commented Jun 25, 2026 •

edited

Loading